-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for timer throttling #698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -170 B (0%) Total Size: 228 kB
|
vishalnarkhede
force-pushed
the
vishal/timer-throttling-fix
branch
from
June 3, 2021 13:58
85b27d3
to
0bc44d0
Compare
…ream-chat-js into vishal/timer-throttling-fix
…ream-chat-js into vishal/timer-throttling-fix
vishalnarkhede
force-pushed
the
vishal/timer-throttling-fix
branch
from
June 7, 2021 10:41
b4bddaf
to
f55157a
Compare
mahboubii
previously approved these changes
Jun 7, 2021
Co-authored-by: Amin Mahboubi <amin@getstream.io>
mahboubii
approved these changes
Jun 7, 2021
jehartzog
pushed a commit
to ourfabriq/stream-chat-js
that referenced
this pull request
Aug 9, 2021
…throttling-fix" This reverts commit 8f1ac69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Latest chrome version came with some intensive timer throttling, which is causing issues with our websocket health check logic (ping-pong). SignalR from microsoft had the same issue as well. https://bugs.chromium.org/p/chromium/issues/detail?id=1186569
If you open codepen and keep in background tab, connection disconnects/reconnects quite frequently, because our “ping” in within setInterval (as shown in screenshot below)
Changelog
setInterval
to adding setTimeout fromonmessage
. So everytime you receive a health-check event on websocket, you schedule a next ping. This is basically to avoid chained timers, which get throttled by chrome - https://developer.chrome.com/blog/timer-throttling-in-chrome-88/#chained-timerspingInterval + 10000 ms
and reconnect to websocket. This bomb should be defused (clearTimeout) everytime you receivehealth.check
event.Testing
If you would like to test this issue
chrome://flags
vishal/timer-throttling-fix
on js client, you won't see any reconnects!!