Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing translation for pinned by #2051

Merged
merged 8 commits into from
Apr 18, 2023
Merged

fix: missing translation for pinned by #2051

merged 8 commits into from
Apr 18, 2023

Conversation

mbezard
Copy link
Contributor

@mbezard mbezard commented Apr 12, 2023 •
edited
Loading

🎯 Goal

Fix this issue : #1365

🛠 Implementation details

Put "Pinned by" text in the translation context

🎨 UI Changes

'Pinned by You' in fr 'Pinned by You' in he (rtl) 'Pinned by { username' in fr
Capture d’écran 2023-04-12 à 19 45 46 Capture d’écran 2023-04-12 à 19 45 00 Capture d’écran 2023-04-12 à 19 47 33
iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

vanGalilea
vanGalilea reviewed Apr 13, 2023
View reviewed changes
package/src/i18n/he.json Outdated Show resolved Hide resolved
package/src/i18n/hi.json Show resolved Hide resolved
package/src/i18n/it.json Show resolved Hide resolved
package/src/i18n/ko.json Outdated Show resolved Hide resolved
@vanGalilea vanGalilea changed the title Fix/missing translation for pinned by fix: missing translation for pinned by Apr 13, 2023
@vanGalilea
Copy link
Contributor

@mbezard, thanks for your lovely contributions, I've adjusted and verified the translations with our native speakers.
Can you please pull our develop branch and merge with your branch?

@mbezard mbezard force-pushed the fix/missing-translation-for-pinned-by branch from b93c901 to e69eb41 Compare April 13, 2023 12:58
@mbezard
Copy link
Contributor Author

mbezard commented Apr 13, 2023

@vanGalilea Thank you for your review. I've updated the branch.

@mbezard mbezard force-pushed the fix/missing-translation-for-pinned-by branch from b9042ab to 4fd3384 Compare April 14, 2023 13:33
@vanGalilea
Copy link
Contributor

I have analyzed this branch locally with sonar cli

@vanGalilea vanGalilea merged commit 478167b into GetStream:develop Apr 18, 2023
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushal87 khushal87 khushal87 left review comments

@skydoves skydoves skydoves left review comments

@sachaarbonel sachaarbonel sachaarbonel left review comments

@EricSSartorius EricSSartorius EricSSartorius left review comments

@vanGalilea vanGalilea vanGalilea approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mbezard @vanGalilea @stream-ci-bot @EricSSartorius @sachaarbonel @skydoves @khushal87