fix(i18n): do not translate command names #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2155 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 307 307
Lines 7094 7094
Branches 2013 2013
=======================================
Hits 5932 5932
Misses 830 830
Partials 332 332
☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Nov 3, 2023
arnautov-anton
approved these changes
Nov 3, 2023
|
Size Change: -1.55 kB (0%) Total Size: 1.9 MB
ℹ️ View Unchanged
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
## [10.16.2](v10.16.1...v10.16.2) (2023-11-03) ### Bug Fixes * **i18n:** do not translate command names ([#2155](#2155)) ([b654b9a](b654b9a))
|
🎉 This PR is included in version 10.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
## [11.0.0-rc.4](v11.0.0-rc.3...v11.0.0-rc.4) (2023-11-08) ### Bug Fixes * **i18n:** add missing SDK translations ([#2157](#2157)) ([e22a6ce](e22a6ce)) * **i18n:** do not translate command names ([#2155](#2155)) ([b654b9a](b654b9a)) * **i18n:** prevent removal of dynamically generated translation keys ([#2154](#2154)) ([ebcaa8f](ebcaa8f)) * List/Item & EmojiPicker async data loading + docs update ([dedefac](dedefac)) ### Features * add Channel prop doDeleteMessageRequest ([#2152](#2152)) ([a01774a](a01774a)) * expose channels state on chat level ([#2161](#2161)) ([7e5543b](7e5543b))
|
🎉 This PR is included in version 11.0.0-rc.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Translation of command names leads to not recognizing the command name in the message string on the back-end and thus breaks the whole commands functionality.