Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with markdown ordered list processing #3234

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Fix an issue with markdown ordered list processing #3234

merged 5 commits into from
Jun 17, 2024

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Jun 6, 2024 •
edited
Loading

🔗 Issue Links

Resolve https://github.com/GetStream/ios-issues-tracking/issues/850

🎯 Goal

  • Fix an issue with markdown ordered list processing

🎨 Showcase

Original text:

The UPS Store

324 S Beverly st

Beverly Hills CA 90210.

Then

The UPS Store

1. S Beverly st

Beverly Hills CA 90210.

Now

The UPS Store

324 S Beverly st

Beverly Hills CA 90210.

🧪 Manual Testing Notes

  • Try an example from the showcase and any other relevant combinations
  • Test ordered list

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Jun 6, 2024
@testableapple testableapple requested a review from a team as a code owner June 6, 2024 10:09
@testableapple testableapple added the 🤞 Ready For QA A PR that is Ready for QA label Jun 6, 2024
@laevandus laevandus added 🟢 QAed A PR that was QAed and removed 🤞 Ready For QA A PR that is Ready for QA labels Jun 6, 2024
@laevandus
Copy link
Contributor

This particular case is now rendered correctly, marking as QAd.

nuno-vieira
nuno-vieira reviewed Jun 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
nuno-vieira
nuno-vieira approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅
LGTM! ✅

@testableapple testableapple enabled auto-merge (squash) June 11, 2024 14:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
129 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@testableapple testableapple merged commit 21a2a48 into develop Jun 17, 2024
6 of 14 checks passed
@testableapple testableapple deleted the fix/md-order-list-processing branch June 17, 2024 09:31
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@laevandus laevandus laevandus approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🟢 QAed A PR that was QAed 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testableapple @laevandus @nuno-vieira