Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #380/shouldUseEnrichEndpoint respect enrich value #382

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

mahboubii
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2020

Size Change: +2 B (0%)

Total Size: 102 kB

Filename Size Change
dist/js/getstream.js 70.2 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/js_min/getstream.js 31.6 kB 0 B

compressed-size-action

@sanchaz
Copy link

sanchaz commented Sep 15, 2020

enrichByDefault -> true
shouldUseEnrichEndpoint receives as params
{ enrich: false, ownReactions: true }

What should shouldUseEnrichEndpoint return?

  • If it should be false, then yes, this fixes it.
  • If it should be true, then no because it will return immediately and not check ownReactions.

Either way this fixes my issue.

@mahboubii
Copy link
Contributor Author

enrichByDefault -> true
shouldUseEnrichEndpoint receives as params
{ enrich: false, ownReactions: true }

What should shouldUseEnrichEndpoint return?

  • If it should be false, then yes, this fixes it.
  • If it should be true, then no because it will return immediately and not check ownReactions.

Either way this fixes my issue.

IMO enrich: false is a more general option and has a higher priority than others

Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas
Copy link
Contributor

IMO enrich: false is a more general option and has a higher priority than others

That's correct.

if no enrich as url param (part of path), then no enrichment.

@ferhatelmas ferhatelmas merged commit b6e97a3 into master Sep 15, 2020
@ferhatelmas ferhatelmas deleted the bug/disable-enrich branch September 15, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants