Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call activity replace #1078

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Call activity replace #1078

merged 4 commits into from
Apr 30, 2024

Conversation

aleksandar-apostolov
Copy link
Collaborator

Replace the various activities in demo-app with the StreamCallActivity implementation.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner April 23, 2024 15:47
skydoves
skydoves approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Nicely done!

It would be also good to have some docs about StreamCallActivity and ComposeStreamCallActivity using this demo code as an example.

@liviu-timar liviu-timar enabled auto-merge (squash) April 30, 2024 09:43
@liviu-timar liviu-timar merged commit 470c4fc into develop Apr 30, 2024
6 checks passed
@liviu-timar liviu-timar deleted the call_activity_replace branch April 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleksandar-apostolov @skydoves @liviu-timar