Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ender Dragon effects and sounds #1781

Merged
merged 8 commits into from
Jan 10, 2021
Merged

Add Ender Dragon effects and sounds #1781

merged 8 commits into from
Jan 10, 2021

Conversation

davchoo
Copy link
Member

@davchoo davchoo commented Jan 2, 2021

This adds wing flap and growl sounds, dragon breath particles, and death explosion particles to the ender dragon fight.

Camotoy
Camotoy requested changes Jan 3, 2021
View reviewed changes
Copy link
Member

@Camotoy Camotoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two other things I noticed:

  • The dragon breath particle (when sitting and breathing its breath) appears to be backwards? Might have been an existing issue in Geyser, I'm unsure.
  • Is there any effect played when the dragon respawns?

connector/src/main/java/org/geysermc/connector/entity/living/monster/EnderDragonEntity.java Show resolved Hide resolved
@davchoo davchoo mentioned this pull request Jan 8, 2021
Merged
@davchoo
Copy link
Member Author

davchoo commented Jan 8, 2021

  • The dragon breath seems to come from the origin of the dragon which might be because of its 0x0x0 bounding box.
  • There are growls during the start of the respawn process, I've PR a mappings addition. Add Ender Dragon respawn sound mappings#48

@Camotoy
Copy link
Member

Camotoy commented Jan 8, 2021

Of course my screenshot didn't save, but when the Ender Dragon was at a very low health, Bedrock was treating it as already dead and played its dying animation. Likely some incongruity with attributes and health.

@Camotoy
Copy link
Member

Camotoy commented Jan 10, 2021

Once that is addressed, is this PR ready for merge?

@davchoo
Copy link
Member Author

davchoo commented Jan 10, 2021

This PR should be ready.

@Camotoy Camotoy merged commit 9232c55 into GeyserMC:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camotoy Camotoy Camotoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davchoo @Camotoy