Entity link cache fixes #2068
Merged
Entity link cache fixes #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this needs to be revisited to see if it's even needed, or perhaps some sort of Guava cache. - `getCachedPlayerEntityLink` now removes the entry if found - Skulls will not have player entity links so we shouldn't bother checking - Clear the entity link cache on dimension switch
rtm516
reviewed
Mar 24, 2021
Comment on lines
+50
to
+54
| Entity entity; | ||
| if (packet.getEntityId() == session.getPlayerEntity().getEntityId()) { | ||
| entity = session.getPlayerEntity(); | ||
| } else { | ||
| entity = session.getEntityCache().getEntityByJavaId(packet.getEntityId()); |
There was a problem hiding this comment.
I never liked doing this but does make sense in this case.
rtm516
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this needs to be revisited to see if it's even needed, or perhaps some sort of Guava cache.
getCachedPlayerEntityLinknow removes the entry if found