Fix building on eclipse #3584
Closed
Fix building on eclipse #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtm516
added
PR: Bugfix
|
Related: KyoriPowered/indra#116 |
|
This will be fixed by bumping Indra in #3505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/KyoriPowered/indra/blob/main/3.x/indra-common/src/main/java/net/kyori/indra/internal/multirelease/IndraMultireleasePlugin.java#L540-L569 for its multi-release system Indra (
net.kyori.indra) seems to make its own decisions about what should and should not be considered a JPMS module. This seems to occur because the isModule check seems to return true in many cases https://github.com/KyoriPowered/indra/blob/main/3.x/indra-common/src/main/java/net/kyori/indra/internal/ModularityDetecter.java#L53-L117.The eclipse plugin can be used to undo this change, and adventure even has to do this for their logger: https://github.com/KyoriPowered/adventure/blob/main/4/text-logger-slf4j/build.gradle.kts#L36-L45.
Note that this only affects behavior for those using the Eclipse IDE (or other implementations of Eclipse Buildship such as the VSCode Java Language Extension). There is absolutely no change to the build process in any other circumstances.
I made a similar PR for issues with building eclipse in Floodgate (GeyserMC/Floodgate#381) and received some internal push back since Eclipse is much less common, especially among those that contribute to this project. But I really don't get this sentiment. I think it benefits Geyser and open source projects in general to make it as easy to contribute as possible. And part of that is making Geyser work in a potential contributors IDE of choice. I think that most people looking to contribute that use Eclipse in the current state of the project would likely just give up and move onto something else, as I doubt they'd be inclined to troubleshoot the obscure behavior of one of the build plugins. While I understand that one response to this may be "just use IntelliJ", I really don't see the argument when we can easily make it compatible with 0 impact on users of other IDEs and Geyser's build and publishing process.