Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version.tag #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create version.tag #178

wants to merge 1 commit into from

Conversation

Greaper88
Copy link
Contributor

Not much to say about this one.

@Chew Chew added the tag PRs relating to tags label Sep 12, 2021
Copy link
Member

@Chew Chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I check grammar now


---

Geyser is built to only support the latest major release of Bedrock at any given time. Betas are not supported, and older version are not supported for maybe more than a minor revision or two for a limited time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Geyser is built to only support the latest major release of Bedrock at any given time. Betas are not supported, and older version are not supported for maybe more than a minor revision or two for a limited time.
Geyser is built to only support the latest stable release of Bedrock at any given time. Betas are not supported, and older versions are not supported for maybe more than a minor revision or two for a limited time.

Copy link
Contributor Author

@Greaper88 Greaper88 Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used major because that means the first two number sets in the version string (i.e. 1.17) whereas anything past that is a minor version.

However, "versions" should be updated, although i think i meant to put "any other version" although that is also a grammar fail.


Geyser is built to only support the latest major release of Bedrock at any given time. Betas are not supported, and older version are not supported for maybe more than a minor revision or two for a limited time.

If you need to use Geyser with your own "outdated" server, you need to install [ViaVersion](https://www.spigotmc.org/resources/viaversion.19254/). You must either: use Java 16 on your server; or if your plugins are not compatible, you must either use the standalone or a Bungeecord/Velocity setup running on Java 16.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you need to use Geyser with your own "outdated" server, you need to install [ViaVersion](https://www.spigotmc.org/resources/viaversion.19254/). You must either: use Java 16 on your server; or if your plugins are not compatible, you must either use the standalone or a Bungeecord/Velocity setup running on Java 16.
If you need to use Geyser with your own "outdated" server, you need to install [ViaVersion](https://www.spigotmc.org/resources/viaversion.19254/). You must use Java 16 on your server. If you cannot run it, we recommend using standalone or Bungeecord/Velocity versions that can run on Java 16.

A lot of "either" here makes this hard to flow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, but I personally don't like the revised wording either... I'll think about it a bit.

Copy link
Contributor Author

@Greaper88 Greaper88 Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must use Java 16 on your server. If you can't or won't run that, we recommend using standalone or Bungeecord/Velocity versions that can run on Java 16.

maybe?

Because some of us won't run it.

Or maybe this

You must use Java 16 on your server that's running Geyser. If you don't go that route, we recommend using standalone or Bungeecord/Velocity versions that can run on Java 16.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Geyser requires Java 16 on your server to run. sounds a bit better than You must use Java 16 on your server.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Geyser requires Java 16 on your server to run. sounds a bit better than You must use Java 16 on your server.

I agree with you.

@Camotoy
Copy link
Member

Camotoy commented Sep 21, 2021

Seems fine from a glance, but I would rather try to pull from some API on which Bedrock versions we support instead of saying "latest stable version".

@Greaper88
Copy link
Contributor Author

That is a really good idea Camotoy, but it would nee a way to be implemented (ofc), and that I have no idea about... Unless we can somehow just pull the version number from Mojang's API or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag PRs relating to tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants