Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghini.desktop still calls its module bauble #324

Closed
mfrasca opened this issue Mar 31, 2018 · 1 comment
Closed

ghini.desktop still calls its module bauble #324

mfrasca opened this issue Mar 31, 2018 · 1 comment
Labels
bug blocker

Comments

@mfrasca
Copy link
Member

mfrasca commented Mar 31, 2018

bauble was the original name of this software, and originally, this software was only desktop. somewhere around 2012 Brett started working at offering bauble as a web service, so he renamed bauble to bauble.classic, and constructed various other projects, calling them b.web, b.webapp, b.api, I think. but the python module was still called bauble. when I moved bauble.classic into ghini and renamed it to ghini.desktop, I briefly considered and quickly discarded the idea of renaming bauble to ghini. now all the plugins within ghini.desktop imports the base library as import bauble, something like Pillow still loading as PIL.

comes windows and the work that @RoDuth did to provide us with easily reproducible steps to get a new installable exe file:
299dd2a18

I don't know if the last line in the above change is at all necessary, but it does break things on the git based software update. with it, the module gets installed in a ghini.desktop egg, that the software doesn't in first instance look for. in first instance the software looks for bauble and whatever the last bauble version you have in your virtual environment, that is what gets loaded, however newer your new ghini.desktop egg.

this had @szlajozs and me a couple of days wondering what was going on.

@mfrasca mfrasca added the bug blocker label Mar 31, 2018
@mfrasca
Copy link
Member Author

mfrasca commented Mar 31, 2018

let's keep it like this, I don't want to spend too much time on this. I've included a cleanup step during install, that will enable people move from bauble to ghini.destkop without noticing.

mfrasca added a commit that referenced this issue Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug blocker
Projects
None yet
Development

No branches or pull requests

1 participant