Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix candi-install errors #41

Closed
Tracked by #40
abearab opened this issue Apr 10, 2024 · 6 comments · Fixed by #46
Closed
Tracked by #40

Fix candi-install errors #41

abearab opened this issue Apr 10, 2024 · 6 comments · Fixed by #46
Assignees
Labels
bug Something isn't working

Comments

@abearab
Copy link
Collaborator

abearab commented Apr 10, 2024

No description provided.

@abearab
Copy link
Collaborator Author

abearab commented Apr 10, 2024

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/data_gilbert/home/aarab/anaconda3/envs/mamba/envs/candi-kg/lib/python3.9/site-packages/CanDI/candi/__init__.py", line 2, in <module>
    data = data.Data() #Global object data instantiated on import required for access by GeneQuery Objects
  File "/data_gilbert/home/aarab/anaconda3/envs/mamba/envs/candi-kg/lib/python3.9/site-packages/CanDI/candi/data.py", line 27, in __init__
    self._init_sources()
  File "/data_gilbert/home/aarab/anaconda3/envs/mamba/envs/candi-kg/lib/python3.9/site-packages/CanDI/candi/data.py", line 42, in _init_sources
    for option in self._parser["data_paths"]:
  File "/data_gilbert/home/aarab/anaconda3/envs/mamba/envs/candi-kg/lib/python3.9/configparser.py", line 963, in __getitem__
    raise KeyError(key)
KeyError: 'data_paths'

@abearab abearab self-assigned this Apr 10, 2024
@abearab abearab pinned this issue Apr 10, 2024
@abearab abearab unpinned this issue Apr 10, 2024
@Yogiski
Copy link
Collaborator

Yogiski commented Apr 20, 2024

Get this error when I try and run the install script.
Happy to take this issue on.

(candi) yogi@Christophers-MacBook-Pro CanDI % python3 CanDI/setup/install.py
Traceback (most recent call last):
  File "/Users/yogi/Projects/CanDI/CanDI/setup/install.py", line 2, in <module>
    from .manager import Manager

@Yogiski
Copy link
Collaborator

Yogiski commented Apr 20, 2024

Also getting that circular import error when i do:

from CanDI import candi

Ran into this before but cant remember what was happening. I'll include the fix in this branch.

@abearab
Copy link
Collaborator Author

abearab commented Apr 21, 2024

@Yogiski – Hi Chris, Thanks for looking into this! I think there are some specific package design choices that you know and it would be best if you could look into this. Let me know if you need my help and I'll be more than happy to talk more about it.

#41 (comment) – I also couldn't load Manager module. I'm not sure what is the reason. I might have caused the issue on my end haha

There are a few details that I have learned:

  1. My understanding is that the default "data" path is problematic as implemented. I made a PyPI for CanDI so I think we need to split the data path from the place CanDI as a package will be installed with pip command. I ran into issues with setting up CanDI using your install command since this will be the relative environment path (I don't remember the exact details). Generally, this will be hard to find as we move forward. I suggest using a local data path to locate datasets with a default location but giving the option so users can change it.

  2. I proposed the option to collect data from CanDI dataverse which is a place to keep any compatible data with CanDI and we can upload them ourself overtime. I think this is more reliable compared to the current implementation. However, it's cool if we can have the depmap API to collect latest data from depmap.

  3. Since we published CanDI I have learned about TDC and gget; also I developed ScreenPro2. I think these two will be cool toolboxes to make CanDI compatible with them. For instance, gget can be a light dependency we can add for useful APIs, etc. TDC will be useful to use CanDI together with other datasets for different tasks (I have done this at least once, plz see this notebook). Also, you may see these discussions.

@abearab abearab removed their assignment Apr 21, 2024
@abearab
Copy link
Collaborator Author

abearab commented Apr 21, 2024

Also getting that circular import error when i do:

from CanDI import candi

Ran into this before but cant remember what was happening. I'll include the fix in this branch.

It would be wonderful if you could fix this, I won't have time now for this but I'll be happy to take care of other issues in parallel.

@abearab abearab added the bug Something isn't working label Apr 21, 2024
@abearab
Copy link
Collaborator Author

abearab commented Jun 23, 2024

Get this error when I try and run the install script. Happy to take this issue on.

(candi) yogi@Christophers-MacBook-Pro CanDI % python3 CanDI/setup/install.py
Traceback (most recent call last):
  File "/Users/yogi/Projects/CanDI/CanDI/setup/install.py", line 2, in <module>
    from .manager import Manager

I think I just needed to use from manager import Manager!
It seems once we do relative import, candi-install can be only used through CLI. i.e.

candi-install --help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants