Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Suppress identity_op lint. #82

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Nov 14, 2023

This code is for tests and is to line up and draw attention to the offsets. Better to suppress than eliminate.

@RalfJung
Copy link
Collaborator

This doesn't seem to work on our oldest supported Rust version, unfortunately.

@waywardmonkeys
Copy link
Contributor Author

This doesn't seem to work on our oldest supported Rust version, unfortunately.

I've re-formulated it and we'll see if that works!

@waywardmonkeys
Copy link
Contributor Author

Could probably clean up all of the #[cfg(allow_clippy)] code by using cfg_attr ... but probably not as part of this PR.

src/offset_of.rs Outdated Show resolved Hide resolved
This code is for tetss and is to line up and draw attention to the
offsets. Better to suppress than eliminate.
@RalfJung
Copy link
Collaborator

That works, thanks!

@RalfJung RalfJung merged commit 804aaab into Gilnaa:master Nov 14, 2023
16 checks passed
@waywardmonkeys waywardmonkeys deleted the suppress-identity-op-lint branch November 17, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants