Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the classed ActUIElement and ActBrowserElement #3822

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Refactored the classed ActUIElement and ActBrowserElement #3822

merged 10 commits into from
Jul 10, 2024

Conversation

Maheshkale447
Copy link
Contributor

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Maheshkale447 and others added 10 commits July 8, 2024 23:00
@Maheshkale447
Merge pull request #3815 from Ginger-Automation/master
7a9f30e 
Pre Merge before Official release 2024.3
@Maheshkale447
Updated Core Common version
9b43508 
Updated few Lambda expressions to use LINQ
@IamRanjeetSingh
fixed warnings
7ac5ace
@IamRanjeetSingh
Bug: From POM window, if we live spy an element. We don't get locator…
8526662 
…s for element.

RC: We didn't learn locators in LearnElementInfoDetails method.
Fix: Learn locators in LearnElementInfoDetails method.
@IamRanjeetSingh
Bug: From POM window, if we try to update elements. We get list of sa…
b901389 
…me elements again.

RC: We did not implement CollectOriginalElementsDataForDeltaCheck & GetMatchingElement methods.
Fix: Implemented CollectOriginalElementsDataForDeltaCheck & GetMatchingElement methods.
@Maheshkale447
Merge pull request #3817 from Ginger-Automation/BugFix/40480-UpdatePO…
0148a73 
…MElementsNotWorking

BugFix - 40480 - Update POM Elements Not Working
@Maheshkale447
Merge pull request #3816 from Ginger-Automation/BugFix/40479-SpyingFr…
547af21 
…omPOMGiveNoLocators

BugFix - 40479 - Spying From POM Gives No Locators
@IamRanjeetSingh
Bug: When we spy an element and try to add it to POM, Ginger hangs an…
67c98f7 
…d crashes.

RC: We were calling AddRange method on Properties and Locator properties of HTMLElementInfo from a background thread. This method call triggers CollectionChanged event, which then modified some UI elements. We cannot modify UI elements from background thread.
Fix: Call AddRange method from outside the background thread and from the calling thread.
@Maheshkale447
Merge pull request #3818 from Ginger-Automation/BugFix/40488-UnableTo…
53f5a4b 
…AddSpiedElementToPOM

BugFix - 40488 - Unable To Add Spied Element To POM
@Maheshkale447
Refactoring of ActUIElement and ActBrowserElement
b3cd989 
Moved ActUIElement and ActBrowserElement classes to CoreCommon from BrowserElement along with their dependancies.
Payload related functions are moved from both the classes and moved to newly created payload helper.
Other changes are small code refactorings
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 10, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

43 files out of 99 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Maheshkale447 Maheshkale447 merged commit 8edea8d into master Jul 10, 2024
6 of 9 checks passed
@Maheshkale447 Maheshkale447 deleted the Feature/ClassRefactor branch July 10, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maheshkale447 @IamRanjeetSingh