Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Build command line with argument values in quotes #245

Closed
GioF71 opened this issue Dec 18, 2023 · 0 comments · Fixed by #246
Closed

[Enhancement] Build command line with argument values in quotes #245

GioF71 opened this issue Dec 18, 2023 · 0 comments · Fixed by #246
Assignees
@GioF71
Labels
enhancement New feature or request

Comments

@GioF71
Copy link
Owner

GioF71 commented Dec 18, 2023 •
edited
Loading

Seems reasonable to put output device in quotes, like for other arguments.
We also want this change applied to every value in order to avoid potential issues with multi-word values
@GioF71 GioF71 self-assigned this Dec 18, 2023
@GioF71 GioF71 added the enhancement New feature or request label Dec 18, 2023
GioF71 added a commit that referenced this issue Dec 18, 2023
@GioF71
[Enhancement] Output device in quotes #245
94e7c04
GioF71 added a commit that referenced this issue Dec 18, 2023
@GioF71
[Enhancement] Output device in quotes #245
0acf1bb 
- add to all parameters
@GioF71 GioF71 changed the title [Enhancement] Output device in quotes [Enhancement] Build command line with argument values in quotes Dec 18, 2023
GioF71 added a commit that referenced this issue Dec 18, 2023
@GioF71
[Enhancement] Build command line with argument values in quotes #245
c2f3893
@GioF71 GioF71 linked a pull request Dec 18, 2023 that will close this issue
[Enhancement] Build command line with argument values in quotes #245 #246
Merged
GioF71 added a commit that referenced this issue Dec 18, 2023
@GioF71
[Enhancement] Build command line with argument values in quotes #245 (#…
a3aa0d9 
…246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GioF71 GioF71

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] Build command line with argument values in quotes #245 GioF71/squeezelite-docker
1 participant
@GioF71