Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversions between DuckDBInterval and TimeSpan #114

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

Seddryck
Copy link
Contributor

As discussed in #112
Close #111

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5383170034

  • 22 of 24 (91.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.14%

Changes Missing Coverage Covered Lines Changed/Added Lines %
DuckDB.NET/DuckDBNativeObjects.cs 22 24 91.67%
Totals Coverage Status
Change from base Build 5379823364: 0.06%
Covered Lines: 757
Relevant Lines: 874

💛 - Coveralls

@Seddryck
Copy link
Contributor Author

Not an expert in SonarQube but I don't think that the build pipeline is failing due to this change

@Giorgi
Copy link
Owner

Giorgi commented Jun 27, 2023

@Seddryck Do you think we also need a method on DuckDBInterval that returns if it fits in TimeSpan or not? In case someone wants to filter items without getting exceptions.

@Seddryck
Copy link
Contributor Author

@Giorgi,

Good call! I'll submit a new PR with your suggestion.

@Giorgi Giorgi merged commit a99da31 into Giorgi:develop Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit operator for DuckDBInterval to TimeSpan
3 participants