Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schema parameter on CreateAppender #95

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Support schema parameter on CreateAppender #95

merged 2 commits into from
Apr 6, 2023

Conversation

Chris-Barton
Copy link
Contributor

@Chris-Barton Chris-Barton commented Apr 6, 2023

This change is to allow the passing of a schema option on the CreateAppender something supported on the native method but not with the ADO.NET Provider. See issue #94

@Giorgi Giorgi changed the base branch from main to develop April 6, 2023 12:17
Copy link
Owner

@Giorgi Giorgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that uses not null schema?

@coveralls
Copy link

coveralls commented Apr 6, 2023

Pull Request Test Coverage Report for Build 4628965211

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 85.781%

Totals Coverage Status
Change from base Build 4628037286: 0.01%
Covered Lines: 712
Relevant Lines: 829

💛 - Coveralls

@Giorgi Giorgi merged commit 25fabdb into Giorgi:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants