Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Update #365

Merged
merged 3 commits into from
Nov 16, 2019
Merged

CI Update #365

merged 3 commits into from
Nov 16, 2019

Conversation

CiaranOMara
Copy link
Contributor

@CiaranOMara CiaranOMara commented Nov 6, 2019

  • Add Julia 1.3 to test matrix.
  • Use the codecov flag in Travis instead of the manual code version.
  • Pkg.instantiate after Pkg.develop.
  • Add colour to make doc output.

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #365 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   40.79%   40.71%   -0.08%     
==========================================
  Files          18       18              
  Lines        3057     3058       +1     
==========================================
- Hits         1247     1245       -2     
- Misses       1810     1813       +3
Impacted Files Coverage Δ
src/cairo_backends.jl 60.18% <0%> (-0.93%) ⬇️
src/svg.jl 71.17% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4a82e...2f583b1. Read the comment docs.

@CiaranOMara CiaranOMara changed the title Fiddle with Travis CI Update Nov 6, 2019
@CiaranOMara CiaranOMara force-pushed the feature/travis branch 2 times, most recently from f4163e5 to ece93e5 Compare November 8, 2019 00:17
@bjarthur
Copy link
Member

bjarthur commented Nov 9, 2019

i'd suggest waiting to merge this until after julia 1.3 comes out, and then not testing compose on 1.2 anymore. it might be awhile, as there is an RC5 planned.

@CiaranOMara
Copy link
Contributor Author

I removed Julia v1.3 from the test matrix so as not to be held up by RC5.

@bjarthur
Copy link
Member

bjarthur commented Nov 9, 2019

was doing instantiate before develop causing a problem? i can't think of a reason why the order would matter.

@CiaranOMara
Copy link
Contributor Author

I don't think the order would have caused any issues as both Pkg.develop() and Pkg.instantiate() should upgrade or downgrade packages as required, and I assume Pkg.jl would arrive at the same solution irrespective of order. In the end, this just matches the order in the Documenter.jl hosting example.

@bjarthur bjarthur merged commit c8a4ab7 into GiovineItalia:master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants