Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't run tests locally without checking out Compose.jl to master #1107

Closed
non-Jedi opened this issue Mar 16, 2018 · 2 comments
Closed

Can't run tests locally without checking out Compose.jl to master #1107

non-Jedi opened this issue Mar 16, 2018 · 2 comments

Comments

@non-Jedi
Copy link
Contributor

non-Jedi commented Mar 16, 2018 •
edited
Loading

GiovineItalia/Compose.jl#278 hasn't made it into a
release yet, but

Gadfly.jl/test/runtests.jl

Line 59 in a5b01ff

"pgf" => name -> PGF(joinpath(outputdir,"$(name).tex"))

uses the PGF call without "optional" args.

This is probably fine, but it should be documented somewhere if it's expected
that you have master of Compose to do development on Gadfly.
@bjarthur
Copy link
Member

definitely worth documenting that Compose master is needed when developing Gadfly. we do already have a development section in the docs. that would be the logical place.

@bjarthur
Copy link
Member

bjarthur commented Jun 2, 2018

fixed by #1116

@bjarthur bjarthur closed this as completed Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjarthur @non-Jedi