Skip to content

Conversation

rowanoulton
Copy link
Contributor

@rowanoulton rowanoulton commented May 3, 2016

Hey,

I've put together a fork to support the --use argument, in the same way that postcss-cli does. It's purely selfish in that I'm used to the postcss-cli approach and wanted to emulate it here with your excellent module.

I don't know if this is something you'd be interested in merging and I certainly understand if it's not a direction you'd like to take but I wanted to share it with you incase it's useful anyway. If you are keen, I could look to extend it to support both styles of config and avoid any breaking changes for existing users.

Let me know what you think, and cheers for the super useful project ✌️

@rowanoulton rowanoulton changed the title Support for --use Support for --use May 3, 2016
@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage decreased (-9.8%) to 90.196% when pulling a134552 on rowanoulton:feature-use-support into 4df0b19 on GitScrum:master.

@Scrum
Copy link
Member

Scrum commented May 3, 2016

Hey !

I would like to leave the current functionality and add your wonderful idea.

I can realize for you this option in the near future or make your pull request which will retain the current functionality.

Thank you for your interest in the project. 👍

@Scrum
Copy link
Member

Scrum commented May 5, 2016

@rowanoulton I added yours wonderful idea. Now you need to update the package and use --use.
Close this PR ?

@rowanoulton
Copy link
Contributor Author

@gitscrum Awesome, appreciate you bundling it in.

Does it support plugin options passed in as arguments? An example here which permits you do to something like:

posthtml -u posthtml-custom-elements --posthtml-custom-elements.defaultTag "span"

@Scrum
Copy link
Member

Scrum commented May 6, 2016

Yep, supports similarly postcss-cli --use and example.
posthtml-cli example use

@Scrum Scrum closed this May 8, 2016
@rowanoulton
Copy link
Contributor Author

@gitscrum hey, apologies for the slow response.

Awesome, thanks for rolling it in!

There is one case that I've noticed isn't supported: config supplied in string format. Example:

posthtml --use posthtml-css-modules --posthtml-css-modules "path/to/styles.css.json" --output dist/index.html --input src/index.html

@Scrum
Copy link
Member

Scrum commented May 9, 2016

@rowanoulton Thank you for showing interest in my pack and bug report. I created a task on the solution of this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants