fixes #1309 by setting confirm to false #2091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamyPesse please merge this, our circle builds are arbitrarily failing because gitbooks just doesnt work sometimes. This PR has come back three times because of the core team letting it stagnate and get conflicts, please dont let it happen again. Please just click the green button and release a patch. |
|
Until then folks, do the following in your codebase: Now you can build stuff without it failing. |
|
WHY IS THIS NOT BEING MERGED WHY DO YOU HATE EVERYONE WHO USES YOUR TOOL 😭 |
|
It's nice that you at least got a response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third attempt at fixing #1309, as #1783 and #2091 were both left open so long conflicts started appearing.
Please merge this one soon! :)