refactor

Author: Byron

git-packetline/src/read/async_io.rs

@@ -1,15 +1,13 @@
-use crate::{decode, read::WithSidebands, PacketLine, StreamingPeekableIter, MAX_LINE_LEN, U16_HEX_BYTES};
+use crate::{
+    decode,
+    read::{ExhaustiveOutcome, WithSidebands},
+    PacketLine, StreamingPeekableIter, MAX_LINE_LEN, U16_HEX_BYTES,
+};
 use bstr::ByteSlice;
 use futures_io::AsyncRead;
 use futures_lite::AsyncReadExt;
 use std::io;
 
-type ExhaustiveOutcome<'a> = (
-    bool,                                                      // is_done
-    Option<PacketLine<'static>>,                               // stopped_at
-    Option<io::Result<Result<PacketLine<'a>, decode::Error>>>, // actual method result
-);
-
 /// Non-IO methods
 impl<T> StreamingPeekableIter<T>
 where

git-packetline/src/read/blocking_io.rs

@@ -1,13 +1,11 @@
-use crate::{decode, read::WithSidebands, PacketLine, StreamingPeekableIter, MAX_LINE_LEN, U16_HEX_BYTES};
+use crate::{
+    decode,
+    read::{ExhaustiveOutcome, WithSidebands},
+    PacketLine, StreamingPeekableIter, MAX_LINE_LEN, U16_HEX_BYTES,
+};
 use bstr::ByteSlice;
 use std::io;
 
-type ExhaustiveOutcome<'a> = (
-    bool,                                                      // is_done
-    Option<PacketLine<'static>>,                               // stopped_at
-    Option<io::Result<Result<PacketLine<'a>, decode::Error>>>, // actual method result
-);
-
 /// Non-IO methods
 impl<T> StreamingPeekableIter<T>
 where

git-packetline/src/read/mod.rs

@@ -2,6 +2,12 @@
 use crate::MAX_LINE_LEN;
 use crate::{PacketLine, U16_HEX_BYTES};
 
+type ExhaustiveOutcome<'a> = (
+    bool,                                                                  // is_done
+    Option<PacketLine<'static>>,                                           // stopped_at
+    Option<std::io::Result<Result<PacketLine<'a>, crate::decode::Error>>>, // actual method result
+);
+
 /// Read pack lines one after another, without consuming more than needed from the underlying
 /// [`Read`][std::io::Read]. [`Flush`][PacketLine::Flush] lines cause the reader to stop producing lines forever,
 /// leaving [`Read`][std::io::Read] at the start of whatever comes next.

git-transport/src/client/blocking_io/bufread_ext.rs

@@ -10,8 +10,8 @@ use std::{
 pub type HandleProgress = Box<dyn FnMut(bool, &[u8])>;
 
 /// This trait exists to get a version of a `git_packetline::Provider` without type parameters.
-/// For the sake of usability, it also implements [`std::io::BufRead`] making it trivial to (eventually)
-/// read pack files while keeping the possibility to read individual lines with low overhead.
+/// For the sake of usability, it also implements [`std::io::BufRead`] making it trivial to
+/// read pack files while keeping open the option to read individual lines with low overhead.
 pub trait ExtendedBufRead: io::BufRead {
     /// Set the handler to which progress will be delivered.
     ///