thanks clippy

Author: Byron

cargo-smart-release/src/changelog/parse.rs

@@ -476,7 +476,7 @@ fn headline<'a, E: ParseError<&'a str> + FromExternalError<&'a str, ()>>(i: &'a
     let hashes = take_while(|c: char| c == '#');
     let greedy_whitespace = |i| take_while(|c: char| c.is_whitespace())(i);
     let take_n_digits = |n: usize| {
-        map_res(take_while_m_n(n, n, |c: char| c.is_digit(10)), |num| {
+        map_res(take_while_m_n(n, n, |c: char| c.is_ascii_digit()), |num| {
             u32::from_str(num).map_err(|_| ())
         })
     };

git-object/src/tag/ref_iter.rs

@@ -69,7 +69,7 @@ impl<'a> TagRefIter<'a> {
                 let (i, target) = context("object <40 lowercase hex char>", |i| {
                     parse::header_field(i, b"object", parse::hex_hash)
                 })(i)?;
-                *state = State::TargetKind;
+                *state = TargetKind;
                 (
                     i,
                     Token::Target {
@@ -81,26 +81,29 @@ impl<'a> TagRefIter<'a> {
                 let (i, kind) = context("type <object kind>", |i| {
                     parse::header_field(i, b"type", take_while1(is_alphabetic))
                 })(i)?;
-                let kind = crate::Kind::from_bytes(kind).map_err(|_| {
-                    let err = crate::decode::ParseError::from_error_kind(i, nom::error::ErrorKind::MapRes);
-                    nom::Err::Error(err)
+                let kind = Kind::from_bytes(kind).map_err(|_| {
+                    #[allow(clippy::let_unit_value)]
+                    {
+                        let err = crate::decode::ParseError::from_error_kind(i, nom::error::ErrorKind::MapRes);
+                        nom::Err::Error(err)
+                    }
                 })?;
-                *state = State::Name;
+                *state = Name;
                 (i, Token::TargetKind(kind))
             }
             Name => {
                 let (i, tag_version) = context("tag <version>", |i| {
                     parse::header_field(i, b"tag", take_while1(|b| b != NL[0]))
                 })(i)?;
-                *state = State::Tagger;
+                *state = Tagger;
                 (i, Token::Name(tag_version.as_bstr()))
             }
             Tagger => {
                 let (i, signature) = context(
                     "tagger <signature>",
                     opt(|i| parse::header_field(i, b"tagger", parse::signature)),
                 )(i)?;
-                *state = State::Message;
+                *state = Message;
                 (i, Token::Tagger(signature))
             }
             Message => {

git-ref/src/store/file/log/iter.rs

@@ -24,7 +24,7 @@ pub mod decode {
         }
     }
 
-    impl<'a> std::error::Error for Error {}
+    impl std::error::Error for Error {}
 
     impl Error {
         pub(crate) fn new(err: log::line::decode::Error, line: LineNumber) -> Self {

git-ref/src/store/file/log/line.rs

@@ -108,7 +108,7 @@ pub mod decode {
             }
         }
 
-        impl<'a> std::error::Error for Error {}
+        impl std::error::Error for Error {}
 
         impl Error {
             pub(crate) fn new(input: &[u8]) -> Self {

git-repository/src/object/tree.rs

@@ -40,7 +40,6 @@ impl<'repo> Tree<'repo> {
                     } else {
                         let next_id = entry.oid.to_owned();
                         let handle = self.repo;
-                        drop(entry);
                         drop(self);
                         self = match handle.find_object(next_id)?.try_into_tree() {
                             Ok(tree) => tree,

git-repository/src/repository/object.rs

@@ -55,7 +55,6 @@ impl crate::Repository {
         match self.objects.try_find(&id, &mut buf)? {
             Some(obj) => {
                 let kind = obj.kind;
-                drop(obj);
                 Ok(Some(Object::from_data(id, kind, buf, self)))
             }
             None => Ok(None),

git-revision/src/spec/parse/function.rs

@@ -207,9 +207,12 @@ fn revision<'a>(mut input: &'a BStr, delegate: &mut impl Delegate) -> Result<&'a
             })
             .or_else(|| {
                 name.is_empty().then(|| ()).or_else(|| {
-                    let res = delegate.find_ref(name)?;
-                    has_ref_or_implied_name = true;
-                    res.into()
+                    #[allow(clippy::let_unit_value)]
+                    {
+                        let res = delegate.find_ref(name)?;
+                        has_ref_or_implied_name = true;
+                        res.into()
+                    }
                 })
             })
             .ok_or(Error::Delegate)?;

git-tempfile/tests/tempfile/fs/remove_dir.rs

@@ -118,7 +118,7 @@ mod empty_depth_first {
         create_dir_all(tree_parent.join("one").join("two").join("three")).unwrap();
         create_dir_all(tree_parent.join("c")).unwrap();
         for empty in &[nested_parent, single_parent, tree_parent] {
-            let _ = git_tempfile::remove_dir::empty_depth_first(empty).unwrap();
+            git_tempfile::remove_dir::empty_depth_first(empty).unwrap();
         }
     }
 }

git-transport/tests/client/git.rs

@@ -73,6 +73,7 @@ async fn handshake_v1_and_request() -> crate::Result {
     while let Some(line) = lines.next().await {
         refs.push(line?)
     }
+    #[allow(clippy::drop_non_drop)] // needed for non-async version
     drop(lines);
 
     assert_eq!(