refactor: Prefer integration level tests, but use unit-tests where appropriate

Author: Byron

git-object/src/borrowed/util.rs renamed to git-object/src/borrowed/util/mod.rs

@@ -109,3 +109,6 @@ pub(crate) fn parse_signature(i: &[u8]) -> IResult<&[u8], Signature, Error> {
         },
     ))
 }
+
+#[cfg(test)]
+mod tests;

git-object/src/borrowed/util/tests.rs

@@ -0,0 +1,76 @@
+mod parse_signature {
+    use crate::borrowed::util::parse_signature;
+    use crate::borrowed::Signature;
+    use crate::{Sign, Time};
+    use bstr::ByteSlice;
+
+    fn signature(
+        name: &'static str,
+        email: &'static str,
+        time: u32,
+        sign: Sign,
+        offset: i32,
+    ) -> Signature<'static> {
+        Signature {
+            name: name.as_bytes().as_bstr(),
+            email: email.as_bytes().as_bstr(),
+            time: Time { time, offset, sign },
+        }
+    }
+
+    #[test]
+    fn tz_minus() {
+        assert_eq!(
+            parse_signature(b"Sebastian Thiel <byronimo@gmail.com> 1528473343 -0230")
+                .unwrap()
+                .1,
+            signature(
+                "Sebastian Thiel",
+                "byronimo@gmail.com",
+                1528473343,
+                Sign::Minus,
+                -9000
+            )
+        );
+    }
+
+    #[test]
+    fn tz_plus() {
+        assert_eq!(
+            parse_signature(b"Sebastian Thiel <byronimo@gmail.com> 1528473343 +0230")
+                .unwrap()
+                .1,
+            signature(
+                "Sebastian Thiel",
+                "byronimo@gmail.com",
+                1528473343,
+                Sign::Plus,
+                9000
+            )
+        );
+    }
+
+    #[test]
+    fn negative_offset_0000() {
+        assert_eq!(
+            parse_signature(b"Sebastian Thiel <byronimo@gmail.com> 1528473343 -0000")
+                .unwrap()
+                .1,
+            signature(
+                "Sebastian Thiel",
+                "byronimo@gmail.com",
+                1528473343,
+                Sign::Minus,
+                0
+            )
+        );
+    }
+
+    #[test]
+    fn empty_name_and_email() {
+        assert_eq!(
+            parse_signature(b" <> 12345 -1215").unwrap().1,
+            signature("", "", 12345, Sign::Minus, -44100)
+        );
+    }
+}

git-object/src/tests/borrowed/mod.rs

@@ -22,80 +22,3 @@ fn signature(time: u32) -> Signature<'static> {
         },
     }
 }
-
-mod parse_signature {
-    use crate::borrowed::util::parse_signature;
-    use crate::borrowed::Signature;
-    use crate::{Sign, Time};
-    use bstr::ByteSlice;
-
-    fn signature(
-        name: &'static str,
-        email: &'static str,
-        time: u32,
-        sign: Sign,
-        offset: i32,
-    ) -> Signature<'static> {
-        Signature {
-            name: name.as_bytes().as_bstr(),
-            email: email.as_bytes().as_bstr(),
-            time: Time { time, offset, sign },
-        }
-    }
-
-    #[test]
-    fn tz_minus() {
-        assert_eq!(
-            parse_signature(b"Sebastian Thiel <byronimo@gmail.com> 1528473343 -0230")
-                .unwrap()
-                .1,
-            signature(
-                "Sebastian Thiel",
-                "byronimo@gmail.com",
-                1528473343,
-                Sign::Minus,
-                -9000
-            )
-        );
-    }
-
-    #[test]
-    fn tz_plus() {
-        assert_eq!(
-            parse_signature(b"Sebastian Thiel <byronimo@gmail.com> 1528473343 +0230")
-                .unwrap()
-                .1,
-            signature(
-                "Sebastian Thiel",
-                "byronimo@gmail.com",
-                1528473343,
-                Sign::Plus,
-                9000
-            )
-        );
-    }
-
-    #[test]
-    fn negative_offset_0000() {
-        assert_eq!(
-            parse_signature(b"Sebastian Thiel <byronimo@gmail.com> 1528473343 -0000")
-                .unwrap()
-                .1,
-            signature(
-                "Sebastian Thiel",
-                "byronimo@gmail.com",
-                1528473343,
-                Sign::Minus,
-                0
-            )
-        );
-    }
-
-    #[test]
-    fn empty_name_and_email() {
-        assert_eq!(
-            parse_signature(b" <> 12345 -1215").unwrap().1,
-            signature("", "", 12345, Sign::Minus, -44100)
-        );
-    }
-}