change!: Remove custom graph::CommitterTimestamp in favor of gix-date::SecondsSinceUnixEpoch.

After all, these are meant to be the same.

Author: Byron

Cargo.lock

@@ -15,6 +15,7 @@ doctest = false
 [dependencies]
 gix-hash = { version = "^0.11.2", path = "../gix-hash" }
 gix-object = { version = "^0.30.0", path = "../gix-object" }
+gix-date = { version = "^0.5.1", path = "../gix-date" }
 gix-hashtable = { version = "^0.2.1", path = "../gix-hashtable" }
 gix-commitgraph = { version = "^0.16.0", path = "../gix-commitgraph" }
 

gix-revwalk/Cargo.toml

@@ -1,7 +1,8 @@
+use gix_date::SecondsSinceUnixEpoch;
 use smallvec::SmallVec;
 
 use super::LazyCommit;
-use crate::graph::{Commit, CommitterTimestamp, Either, Generation};
+use crate::graph::{Commit, Either, Generation};
 
 impl<'graph> LazyCommit<'graph> {
     /// Return an iterator over the parents of this commit.
@@ -17,11 +18,9 @@ impl<'graph> LazyCommit<'graph> {
     ///
     /// This is the single-most important date for determining recency of commits.
     /// Note that this can only fail if the commit is backed by the object database *and* parsing fails.
-    pub fn committer_timestamp(&self) -> Result<CommitterTimestamp, gix_object::decode::Error> {
+    pub fn committer_timestamp(&self) -> Result<SecondsSinceUnixEpoch, gix_object::decode::Error> {
         Ok(match &self.backing {
-            Either::Left(buf) => {
-                gix_object::CommitRefIter::from_bytes(buf).committer()?.time.seconds as CommitterTimestamp
-            }
+            Either::Left(buf) => gix_object::CommitRefIter::from_bytes(buf).committer()?.time.seconds,
             Either::Right((cache, pos)) => cache.commit_at(*pos).committer_timestamp(),
         })
     }
@@ -50,7 +49,7 @@ impl<'graph> LazyCommit<'graph> {
                         Token::Parent { id } => parents.push(id),
                         Token::Author { .. } => {}
                         Token::Committer { signature } => {
-                            timestamp = Some(signature.time.seconds as CommitterTimestamp);
+                            timestamp = Some(signature.time.seconds);
                             break;
                         }
                         _ => {

gix-revwalk/src/graph/commit.rs

@@ -10,9 +10,7 @@ pub mod commit;
 
 mod errors;
 pub use errors::{insert_parents, lookup};
-
-/// The time in seconds since unix epoch at which a commit was created.
-pub type CommitterTimestamp = u64;
+use gix_date::SecondsSinceUnixEpoch;
 
 /// The generation away from the HEAD of graph, useful to limit algorithms by topological depth as well.
 ///
@@ -74,7 +72,7 @@ impl<'find, T> Graph<'find, T> {
     pub fn insert_parents(
         &mut self,
         id: &gix_hash::oid,
-        mut new_parent_data: impl FnMut(gix_hash::ObjectId, CommitterTimestamp) -> T,
+        mut new_parent_data: impl FnMut(gix_hash::ObjectId, SecondsSinceUnixEpoch) -> T,
         mut update_existing: impl FnMut(gix_hash::ObjectId, &mut T),
         first_parent: bool,
     ) -> Result<(), insert_parents::Error> {
@@ -266,7 +264,7 @@ pub struct Commit<T> {
     /// The parents of the commit.
     pub parents: SmallVec<[gix_hash::ObjectId; 1]>,
     /// The time at which the commit was created.
-    pub commit_time: CommitterTimestamp,
+    pub commit_time: SecondsSinceUnixEpoch,
     /// The generation of the commit, if available.
     pub generation: Option<u32>,
     /// Any kind of data to associate with this commit.