Skip to content

Conversation

Byron
Copy link
Member

@Byron Byron commented Jun 23, 2024

Fixes #1416.

Tasks

  • reproduce issue
  • fix it
  • add mailmap check to the CLI

@Byron Byron marked this pull request as ready for review June 23, 2024 14:04
Copy link
Contributor

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more comprehensive than what I had started to write! I noticed one small issue.

Co-authored-by: Emily <github@emily.moe>
@Byron Byron merged commit f107014 into main Jun 23, 2024
@Byron Byron deleted the fix-mailmap branch June 23, 2024 14:31
@Byron
Copy link
Member Author

Byron commented Jun 23, 2024

Thanks for the review!

And here is the new release: https://github.com/Byron/gitoxide/releases/tag/gix-mailmap-v0.23.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gix-mailmap parser treats mappings with old but not new names as an error

2 participants