This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Og membership state cache context #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
amitaibu
commented
Sep 4, 2016
•
amitaibu
commented
|
Update: I'm still seeing |
|
/cc @pfrenssen |
amitaibu
changed the title
|
Things I need to figure (but pointers would be appreciated of course):
|
|
Following this with great interest. I'm going to try to get some time assigned to review this. |
|
@pfrenssen hi! In the mean time @DavidHernandez and me were able to add unit tests :) |
amitaibu
changed the title
| public function getContext() { | ||
| if (!$route_contexts = $this->routeMatch->getRouteObject()->getOption('parameters')) { | ||
| // No "parameters" defined in the route. | ||
| return 'none'; |
There was a problem hiding this comment.
Can we use a constant instead of hardcoding none?
|
I've disabled development mode on my local, and was able to see a |
|
Oh, I thought I got it in already. Fixed the sniffer mistakes. Once green, I'll merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.