allow checkboxes/radios #311
Conversation
chx
force-pushed
the
radios
branch
2 times, most recently
from
6689fcc
to
ca4d91a
Compare
| @@ -160,7 +161,7 @@ function og_entity_create_access(AccountInterface $account, array $context, $bun | |||
| $handler = Og::getSelectionHandler($field_definition); | |||
|
|
|||
| if ($handler->getReferenceableEntities()) { | |||
| return Accessresult::neutral(); | |||
| return AccessResult::neutral(); | |||
There was a problem hiding this comment.
@RoySegall we are probably missing a Kernel test to cover this line, would you mind creating a test in a separate PR?
There was a problem hiding this comment.
PHP classnames are not case sensitive but file systems might be so this is an interesting bug which might not trigger ever... but it's better be fixed.
|
I took out the |
|
I've restarted Travis, I suspect there's something in the GroupTab tests that randomly fails, but it's not related to this PR. |
|
Merged, thanks. Btw, next time you can open a PR against Gizra/og -- moved it back there to get more visibility |
|
Oh, and completely off topic - I'd be happy if you could maybe point me in the right direction with Gizra#163 (comment) |
Throw an exception when calling `MembershipManager::getGroupIds()` with an entity which is not group content
This allows using checkboxes/radios