Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues that arose since the MemoryFile PR #265 #289

Merged
merged 28 commits into from
Sep 1, 2022

Conversation

adehecq
Copy link
Member

@adehecq adehecq commented Aug 30, 2022

Since the MemoryFile PR #265, several functionalities seem to have been broken. Some bugs were revealed by current tests, but it also highlighted the lack of robust tests for certain functionalities.

@adehecq adehecq marked this pull request as draft August 30, 2022 11:49
tests/test_georaster.py Outdated Show resolved Hide resolved
tests/test_georaster.py Outdated Show resolved Hide resolved
@adehecq adehecq marked this pull request as ready for review August 31, 2022 15:53
@adehecq adehecq linked an issue Aug 31, 2022 that may be closed by this pull request
Copy link
Contributor

@rhugonnet rhugonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!! 🥳
In particular the new tests which will make things a lot more robust. It's exhausting work 💪, and not so rewarding in the short-term, but so much worth it in the long-term!

We've come quite a way since a year and a half ago, I think we're really getting close to a stable, solid core that we (hopefully) won't have to change so much in the future 🥲. Then we can focus on adding new features (and the science that goes with it)!

.github/workflows/python-app.yml Show resolved Hide resolved
geoutils/georaster/raster.py Show resolved Hide resolved
geoutils/georaster/raster.py Show resolved Hide resolved
tests/test_georaster.py Show resolved Hide resolved
tests/test_georaster.py Outdated Show resolved Hide resolved
tests/test_georaster.py Show resolved Hide resolved
tests/test_georaster.py Outdated Show resolved Hide resolved
tests/test_georaster.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants