-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several issues that arose since the MemoryFile PR #265 #289
Conversation
…d associated tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!! 🥳
In particular the new tests which will make things a lot more robust. It's exhausting work 💪, and not so rewarding in the short-term, but so much worth it in the long-term!
We've come quite a way since a year and a half ago, I think we're really getting close to a stable, solid core that we (hopefully) won't have to change so much in the future 🥲. Then we can focus on adding new features (and the science that goes with it)!
Since the MemoryFile PR #265, several functionalities seem to have been broken. Some bugs were revealed by current tests, but it also highlighted the lack of robust tests for certain functionalities.
Raster.crop()
has an erroneous right bound #287