Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skgstat version to latest fixes #207

Merged
merged 12 commits into from
Sep 7, 2021

Conversation

rhugonnet
Copy link
Contributor

Was not working for CI before (skgstat release too recent?), should work now.
Resolves #203

@rhugonnet
Copy link
Contributor Author

Got a multiprocessing error building the docs that doesn't seem linked to our code, and that I don't get locally 🤔

Rerunning...

@rhugonnet
Copy link
Contributor Author

@erikmannerfelt @adehecq As you can see, during CI, sphinx fails in test_docs/test_build with a multiprocessing error. And this even without changing anything to the current main. So it was passing a couple weeks ago and now it fails... Any ideas?

@rhugonnet
Copy link
Contributor Author

I checked all package versions of sphinx and sphinx submodules fetched by conda/mamba between the CI that use to pass in the PRs of a couple weeks ago, and this CI, and they are exactly the same.
Must come from somewhere else...

@rhugonnet
Copy link
Contributor Author

I temporarily changed the number of cores for sphinx to use during CI to 1, and opened an issue so that we can fix it.

@rhugonnet
Copy link
Contributor Author

I temporarily changed the number of cores for sphinx to use during CI to 1, and opened an issue so that we can fix it.

Literaly one issue fixed, one issue opened 😓

@rhugonnet
Copy link
Contributor Author

FYI: force merging those 3 lines of change so that the CI works for other PRs

@rhugonnet rhugonnet merged commit cdfc8fd into GlacioHack:main Sep 7, 2021
@rhugonnet rhugonnet deleted the skgstat_compat branch September 7, 2021 06:23
@erikmannerfelt
Copy link
Contributor

Wow, that was weird... Looking at the test execution time, however, I don't really see a difference, so that's good at least

@adehecq
Copy link
Member

adehecq commented Sep 8, 2021

Weird error indeed... Sorry I can't really help on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update skgstat version in environment file to 0.6.8
3 participants