Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable blockwise test #214

Merged

Conversation

erikmannerfelt
Copy link
Contributor

Closes #211.

I don't know what you're smoking, @rhugonnet, but this works fine on my end! Was it CI or locally that it failed for you? For me, both pass.

@erikmannerfelt erikmannerfelt added bug Something isn't working test-suite Issue related to testing labels Sep 10, 2021
@rhugonnet
Copy link
Contributor

Closes #211.

I don't know what you're smoking, @rhugonnet, but this works fine on my end! Was it CI or locally that it failed for you? For me, both pass.

I wish I was smoking good stuff! 🚬 🤟
But it's probably a CI issue from another package that's been solved since yesterday... I'm certain it wasn't passing on CI (but I'm not sure they keep the logs except for the last run of a PR).

Well all good! This way we don't have to go chasing all the bugs introduced by other packages... just being patient is enough 😃

On this same subject: we could also try resetting multiprocessing for the sphinx build at some point, they might have corrected the issue if it came from there (not directly them at least as I checked the version hadn't changed... but maybe a dependency).

@erikmannerfelt erikmannerfelt merged commit 477d948 into GlacioHack:main Sep 13, 2021
@erikmannerfelt erikmannerfelt deleted the reenable-blockwise-test branch August 16, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test-suite Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_blockwise_coreg_large_gaps fails with all NaN assertion in coreg.apply_matrix
2 participants