Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spatial tools #228

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Remove spatial tools #228

merged 3 commits into from
Oct 25, 2021

Conversation

atedstone
Copy link
Member

@atedstone atedstone commented Oct 22, 2021 •
edited
Loading

New PR to replace #226 which was closed permanently by accidental branch deletion...

@atedstone
Copy link
Member Author

Build cancelled manually. Requires geoutils v0.0.5 to be built on conda-forge first.

rhugonnet
rhugonnet approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@rhugonnet rhugonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good 👍 Thanks for tackling this Andrew!
Out of curiosity: did you use a refactoring functionality (e.g. like that of PyCharm?)
I think the function subtract_rasters was removed entirely? Maybe this could appear in the PR description.

erikmannerfelt
erikmannerfelt approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@erikmannerfelt erikmannerfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@atedstone atedstone merged commit 6613178 into GlacioHack:main Oct 25, 2021
@atedstone atedstone deleted the remove-spatial-tools branch October 25, 2021 12:06
@atedstone
Copy link
Member Author

All looks good 👍 Thanks for tackling this Andrew! Out of curiosity: did you use a refactoring functionality (e.g. like that of PyCharm?) I think the function subtract_rasters was removed entirely? Maybe this could appear in the PR description.

Note added about substract_rasters in the final commit info for the PR ✅

And nope, I didn't use any special refactoring functionality, just lots of cross-project 'search and replace' in Sublime Text 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikmannerfelt erikmannerfelt erikmannerfelt approved these changes

@rhugonnet rhugonnet rhugonnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atedstone @rhugonnet @erikmannerfelt