Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DEM.copy with new_array argument #240

Merged
merged 13 commits into from
Nov 18, 2021
Merged

Fix DEM.copy with new_array argument #240

merged 13 commits into from
Nov 18, 2021

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Nov 17, 2021 •
edited
Loading

Resolves #235
Easy fix, the argument was simply not passed to super() for SatImg

adehecq
adehecq reviewed Nov 17, 2021
View reviewed changes
xdem/dem.py Show resolved Hide resolved
@adehecq adehecq mentioned this pull request Nov 18, 2021
Open
adehecq
adehecq approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added our discussion as a new issue, so that one is good to merge.

@rhugonnet rhugonnet merged commit edde09b into GlacioHack:main Nov 18, 2021
@rhugonnet rhugonnet deleted the dem_copy branch November 18, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehecq adehecq adehecq approved these changes

@erikmannerfelt erikmannerfelt Awaiting requested review from erikmannerfelt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argument new_array of DEM.copy() not working
2 participants
@rhugonnet @adehecq