Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gaussian and exponential models to fit_sum_model_variogram #271

Merged
merged 15 commits into from
Jul 7, 2022

Conversation

rhugonnet
Copy link
Contributor

This PR adds the exponential and spherical models for fitting a sum of model to an empirical variogram.

@rhugonnet
Copy link
Contributor Author

One issue brought up by this PR and the work in https://github.com/rhugonnet/dem_error_study is that we inconsistently use skgstat.models or home-defined variogram models in our functions.
This should be dealt with in the future by relying on single source, preferably from an existing package.

@rhugonnet
Copy link
Contributor Author

Admin-merging this PR as it is only a couple lines

@rhugonnet rhugonnet merged commit 072a84c into GlacioHack:main Jul 7, 2022
@rhugonnet rhugonnet deleted the update_dem_error branch July 7, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant