Fix previously skipped tests that used to fail randomly #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update upstream
rhugonnet
changed the title
adehecq
reviewed
Aug 10, 2022
adehecq
approved these changes
Aug 12, 2022
|
Which version of scipy is needed for the test_fit.py tests to run successfully? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 1 random failing test in
test_fit.pyby removing thepytest.skip(wrong behaviour fixed directly by scipy) and 2 failing tests intest_coreg.pydue to changes inscipy.transform.warpNaN propagation.Details below:
For the failure in
test_fit.py, my best trick for fixing yet: waiting 😄! The issue with the random seed ofscipy.optimize.basin_hoppingseemed to have been fixed directly inscipysince the issue arose. I ran the test several times and it always passes now.For the two tests that were skipped in
test_coreg.py, they relate to issues withskimage.transform.warp. The tests let me think the behaviour has changed with NaNs, but I couldn't find anything in the release notes that would indicate it (https://scikit-image.org/docs/0.19.x/release_notes.html). We should keep in mind it's quite a young package.Basically,
warpnow propagates NaNs with the order of interpolation, exactly the same as the "homemade" mask + dilation calculation that we use to do by default. So, using default parameters, results are unchanged. However, we cannot "ignore" the NaN propagation anymore, if that was part of the intended behaviour (I let @erikmannerfelt check that). There's probably more work needed to decide if we consistently use these functions within the package, as they are currently a bit apart.Resolves #259
Resolves #209