-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error pipeline and adapt documentation #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update upstream
rhugonnet
changed the title
Add error pipeline and simplify documentation on uncertainty analysis
Add error pipeline and adapt documentation
Aug 19, 2022
…relation of errors
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
reviewed
Aug 23, 2022
adehecq
previously approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from mostly minor comments, this looks all good!
Fantastic work !! 👏
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes in
spatialstats.py
:Documentation updated with changes of this branch is here: https://xdem-rhugonnet.readthedocs.io/en/error_pipeline/
This PR:
number_effective_samples
wrapper function and related tests,two_step_standardization
function to consistently rescale the standardization afterinterp_nd_binning
and related tests,infer_heteroscedasticity_from_stable
function (wrapper aroundRaster
andVector
objects) and theestimate_model_heteroscedasticity
function (wrapper ofnd_binning
,interp_nd_binning
andtwo_step_standardization
withnp.ndarray
) functions and tests,infer_spatial_correlation_from_stable
(wrapper aroundRaster
andVector
objects) andestimate_model_spatial_correlation
(wrapper ofsample_empirical_variogram
andfit_sum_model_variogram
withnp.ndarray
) wrapper function and tests,spatial_error_propagation
wrapper function (wrapper aroundRaster
andVector
objects) and tests,plot_infer_heterosc
, "Spatial correlation of errors" inplot_infer_spatial_correlation
and "Spatial propagation of elevation errors" inplot_spatial_error_propagation
for each of the 3 wrapper functions that work directly withRaster
andVector
objects with all steps included,plot_variogram_estimation_modelling.py
, renaming of "Spatial correlation of elevation measurement errors" into "Estimation and modelling of spatial variograms" inplot_variogram_estimation_modelling.py
;Resolves #256