Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify resolution in terrain docstrings #491

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Mar 18, 2024

This PR specifies that the argument resolution is optional in terrain functions, moves it down to the end of the list, and adds a note on aspect independence from resolution.
Tests were adjusted to all pass the resolution argument instead of relying on it as second positional.

Resolves #490

@rhugonnet rhugonnet merged commit 981d7db into GlacioHack:main Mar 18, 2024
13 checks passed
@rhugonnet rhugonnet deleted the clarify_terrain_docstrings branch March 18, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolution attribute missing in terrain.aspect()
1 participant