Rotation camera

[callemand]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add possibility to rotate camera at 90°, 180° and 270°

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5380972) 97.83% compared to head (c82cc47) 97.83%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1823   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         711      711           
  Lines       10951    10970   +19     
=======================================
+ Hits        10714    10733   +19     
  Misses        237      237           

Impacted Files	Coverage Δ
server/services/rtsp-camera/lib/getImage.js	100.00% <100.00%> (ø)
server/services/rtsp-camera/lib/startStreaming.js	100.00% <100.00%> (ø)
server/utils/constants.js	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Pierre-Gilles]

Thanks for this PR ! 🙌

I have a few feedbacks.

I tried it on my machine, and it doesn't work because of a conversion bug in the getImage function.

On the "camera" page, there is an alignment bug on the buttons:

[callemand]

On the "camera" page, there is an alignment bug on the buttons:

I'm not able to have the same behavior on my side. I have show this issue on my production gladys but not on dev.
Do you have a some step to reproduce ?

[Pierre-Gilles]

@callemand I always have the bug, for example with this resolution I have it:

[callemand]

@callemand I always have the bug, for example with this resolution I have it:

It's fixed :)

[Pierre-Gilles]

Works fine now, thanks for the fixes! 🙏

[relativeci]

Job #1629: Bundle Size — 8.59MiB (~+0.01%).

7805e29(current) vs 9ae2c3c master#1628(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)

	Current Job #1629	Baseline Job #1628
Initial JS	4.63MiB(+0.02%)	4.62MiB
Initial CSS	301.84KiB	301.84KiB
Cache Invalidation	53.73%	57.91%
Chunks	47	47
Assets	150	150
Modules	1356	1356
Duplicate Modules	19	19
Duplicate Code	0.67%	0.67%
Packages	124	124
Duplicate Packages	3	3

Total size by type (1 change)

	Current Job #1629	Baseline Job #1628
CSS	315.14KiB	315.14KiB
Fonts	93.55KiB	93.55KiB
HTML	13.58KiB	13.58KiB
IMG	1.92MiB	1.92MiB
JS	6.24MiB (+0.01%)	6.24MiB
Media	0B	0B
Other	15.29KiB	15.29KiB

---

View job #1629 report View master branch activity