fix: some broken tests #2249
Merged
fix: some broken tests #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+54
to
+68
| match (&command, cli.log_mode, cli.verbose) { | ||
| ( | ||
| // User specified a log file, so we should use it. | ||
| Commands::Local(LocalArgs { | ||
| log_file: Some(log_file), | ||
| .. | ||
| }), | ||
| _, | ||
| _, | ||
| ) => logutil::init( | ||
| cli.verbose, | ||
| // Use JSON logging by default when writing to a file. | ||
| cli.log_mode.unwrap_or(LoggingMode::Json).into(), | ||
| Some(log_file), | ||
| ), |
There was a problem hiding this comment.
Since we weren't actually running the tests in this crate, there was a regression in #2187 that went unnoticed.
scsmithr
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we weren't actually running any of the tests in
glaredb/tests. This fixes some issues that were identified when running those tests.Additionally updates the unit test command to properly run all unit tests.