-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustfmt nightly #1767
Rustfmt nightly #1767
Conversation
rustfmt-nightly was forked from rustfmt 0.9 and its version numbering has been reset to 0.1.0. This commit updates the version check to reject rustfmt only if its 0.[1-4].x version is not follwed by '-nightly' suffix.
This is great so far! Would you be interested in converting the existing Examples:
|
@@ -34,7 +34,7 @@ module.exports = class Rustfmt extends Beautifier | |||
else | |||
@run(program, ["--version"], help: help) | |||
.then((stdout) -> | |||
if /^0\.(?:[0-4]\.[0-9])/.test(stdout.trim()) | |||
if /^0\.(?:[0-4]\.[0-9])(?!-nightly)/.test(stdout.trim()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By using "Executables" you could check version with rustfmt.isVersion(YOUR_VERSION)
. See
isVersion1 = ((phpCsFixer.isInstalled and phpCsFixer.isVersion('1.x')) or \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to have a look. Cannot promise I'll have enough free cycles to implement it though.
No worries, @imp. How about I merge this as is and if you have time it would be awesome to have another Pull Request bringing Rustfmt up to speed using the new Executables feature in Atom-Beautify. Thanks for contributing! |
Published to v0.30.5 |
This PR enables running newish rustfmt tool (known as rustfmt-nightly).
Its version numbering scheme has been restarted from 0.1.0.
To whitelist these new builds, the version regex was changed to only trigger when the version numbers are NOT followed by
-nightly
suffix.See #358
Check all those that are applicable and complete.
master
branchnpm run docs
CHANGELOG.md
under "Next" section