-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Black beautifier for Python #2189
Conversation
CI checks are failing because black requires python 3.6.0+ to run. Should I try updating the |
I'm trying to remember if you can include this in
For appveyor.yml, change the two If pip3 is necessary, change that as well. |
I'm running some CI tests on a new branch, will update here when that's working. |
Here's what we use for beautifier-black: https://github.com/Unibeautify/beautifier-black/blob/master/.travis.yml |
Arg. The above works for linux to install black, which then fails afterward because fuse, react, and various language packages, fail to load. edit: I really can't figure out how to get pip3 working. I've tried about 2 dozen configurations, and now I'm getting errors in travis on totally unrelated lines like |
Reverted to a version that doesn't install Black for travisCI checks. No idea why AppVeyor is now failing on |
Yea I can't install language-marko locally either. Not sure how Travis was able to pass. |
Looks like appveyor was also failing on the master branch for the same reason. Also I accidentally hit close. Many mistakes. |
Thanks for contributing! |
What does this implement/fix? Explain your changes.
Adds support for the Black python beautifier.
Does this close any currently open issues?
Closes #2144
Any other comments?
Currently does not support line length option, since Black uses a different default from autopep8 and yapf which I did not want to overwrite. (Is there a supported way to set this on an executable-basis?)
I also did not see how to set up test examples for specific beautifiers, instead of specific languages. Is there a way to do this?
Checklist
master
branchnpm run docs
CHANGELOG.md
under "Next" section