Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokémon Generation argument #832

Merged
merged 9 commits into from
May 2, 2024
Merged

Pokémon Generation argument #832

merged 9 commits into from
May 2, 2024

Conversation

Glazelf
Copy link
Owner

@Glazelf Glazelf commented May 1, 2024

Add generation argument to most Pokémon subcommands.
To Do:

  • Add argument
  • Make argument read
  • Add button interactivity
  • Make move and ability Pokémon list adaptive to generation argument
  • Adapt autocomplete
  • Fix some sorting issues, especially in autocomplete
  • Fix learnset argument
  • Testing

Closes #420

@Glazelf Glazelf self-assigned this May 1, 2024
@Glazelf Glazelf marked this pull request as draft May 1, 2024 21:54
Sort by number from now on, also clean some strings, image issues and filter allPokemon some more
Might have some small bugs but should also be a lot cleaner of an implementation.
Fix some sorting issue?
Is thrown out of order by filtering for some reason
Sorting:
- Pokémon: num
- Ability & Moves: alphabetically
@Glazelf Glazelf marked this pull request as ready for review May 2, 2024 15:47
@Glazelf Glazelf merged commit cda4f88 into master May 2, 2024
2 checks passed
@Glazelf Glazelf added the enhancement New feature or request label May 2, 2024
@Glazelf Glazelf deleted the pokemon-generations branch May 11, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generation argument for Pokémon
1 participant