Add method check to whipHandler #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ChaseCares Interested in getting involved! Would love to have you as an admin :) I need help triaging/staying on top of issues. |
|
I am certainly willing to help, when I can. I don't know if I have the knowledge/experience to actually make a difference though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method check to whipHandler to prevent empty streams from being created by OBS users. I believe this is why there are streams listed in /api/status that are broken.
OBS sends a DELETE request when the stream is terminated, see screenshot of packet capture.
I believe the
DELETErequest can safely be ignored as removal of the streamkey/info is handled hereEdit, sorry for the multiple commits, I think an earlier return is more appropriate?
Let me know if there is anything else I can do, thanks.
Chase