Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service connections can take an unexpected amount of time to close #21

Open
clone1018 opened this issue Sep 19, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@clone1018
Copy link
Member

Under certain conditions, when a client is reconnecting, there can be a race condition where the client is reconnecting but the services have not finished closing out their connections yet. This causes the stream to still exist in the stream manager state, even though the client is completely disconnected.

I don't think asyncing the service connection closers is the right approach here, because that could cause issues upstream. Likely there's a bug with one of the relay connections and the close call is hanging. If the relay connection hangs, I suspect we can ignore it since it's unique to the particular stream. Need to research more about writing to broken sockets.

I suspect this is related to #20

@clone1018 clone1018 added the bug Something isn't working label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant