Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnose video studdering on low movement scenes #5

Open
clone1018 opened this issue Aug 25, 2021 · 0 comments
Open

Diagnose video studdering on low movement scenes #5

clone1018 opened this issue Aug 25, 2021 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@clone1018
Copy link
Member

Currently when streaming a movie, the scene will play very nicely since there's constant movement. However when switching to a more static scene we see h264 decoding errors popup in our janus-ftl-plugin edge, and the video no longer appears stable.

More details:

rtmp-ingest/rtmp.go

Lines 271 to 289 in 98e8d35

// So the video is jittering, especially on screens with no movement.
// To reproduce, play clock scene, see it working, and then switch to desktop scene
// You can see in the chrome inspector that the keyframes decoded drops. You can also see the weird video problems
// happen on the clock scene, which show up in the keyframe decoded drops.
// I want to log the keyframes tomorrow to see if we stop getting them on the ingest side.
// Also there's some bullshit in Janus to look at
// Pion WebRTC also provides a SampleBuilder. This consumes RTP packets and returns samples. It can be used to
// re-order and delay for lossy streams. You can see its usage in this example in daf27b.
// https://github.com/pion/webrtc/issues/1652
// https://github.com/pion/rtsp-bench/blob/master/server/main.go
// https://github.com/pion/obs-wormhole/blob/master/internal/rtmp/rtmp.go
//start := time.Now()
for _, p := range packets {
if err := h.stream.WriteRTP(p); err != nil {
return err
}
}

@clone1018 clone1018 added bug Something isn't working help wanted Extra attention is needed labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant