Support package with SemVer2 version with buildMetadata #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoC0de
force-pushed
the
feature/support-semver2-build-metadata
branch
3 times, most recently
from
b154f35
to
6be732b
Compare
JoC0de
force-pushed
the
feature/support-semver2-build-metadata
branch
from
6be732b
to
ccc2c66
Compare
JoC0de
commented
Jul 23, 2023
JoC0de
commented
Jul 23, 2023
igor84
reviewed
Jul 24, 2023
| /// Initializes a new instance of the <see cref="SemVer2Version" /> struct. | ||
| /// </summary> | ||
| /// <param name="dummy">Dummy to allow calling this constructor.</param> | ||
| public SemVer2Version(bool dummy) |
There was a problem hiding this comment.
Maybe a better option would be a static SemVer2Version Create() method?
There was a problem hiding this comment.
I never used struct in a old C# language version where there Default constructor is not supported.
I just didn't hat that in mind. If you like you can change it.
igor84
reviewed
Jul 24, 2023
| /// </summary> | ||
| /// <param name="withBuildMetadata">If <c>true</c> the <see cref="buildMetadata" /> is included.</param> | ||
| /// <returns>The formatted string.</returns> | ||
| public string ToString(bool withBuildMetadata = false) |
There was a problem hiding this comment.
This is reporting a warning Method with optional parameter is hidden by overload. Is there a reason this parameter is optional?
There was a problem hiding this comment.
No you can remove the = false. I need to install ReSharper 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #540