Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing installation duration #566

Merged
merged 9 commits into from
Sep 23, 2023
Merged

Conversation

popara96
Copy link
Collaborator

Avoid deleting folders during clean after install by skipping the extraction of unneeded folders and files. #557

src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
@JoC0de JoC0de linked an issue Sep 19, 2023 that may be closed by this pull request
Copy link
Collaborator

@JoC0de JoC0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review, I didn't had much time ...

src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/NugetPackageInstaller.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/PackageContentManager.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/PackageContentManager.cs Outdated Show resolved Hide resolved
@JoC0de JoC0de merged commit d395401 into master Sep 23, 2023
8 checks passed
@JoC0de JoC0de deleted the optimize-installation-decompress branch September 23, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop decompressing files that are not needed to speed up installing
3 participants