Shortening the path of source files in source code nuget packages #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor84
approved these changes
Oct 6, 2023
JoC0de
requested changes
Oct 6, 2023
|
Will write tests tomorrow. |
popara96
commented
Oct 9, 2023
| [Test] | ||
| [TestCase("Microsoft.Azure.WebJobs.Sources", "3.0.37")] | ||
| [TestCase("NServiceBus.Testing.Fakes.Sources", "7.1.13")] | ||
| public void TestSourceCodePackageInstall(string packageId, string packageVersion) |
There was a problem hiding this comment.
I added a check to see if Sources directory is added in the package root and ensured that contentFiles directory doesn't exist. I'm trying to thing of other generic checks that we could do while installing this but nothing comes to mind as directories/files under Sources will be very package-specific. H
JoC0de
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will sort out long paths made by source code packages by unpacking all source files inside the packageDirectory/Sources.