added headings support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request adds support for markdown-style headings. The changes include adding new CSS classes for different heading levels in 'assets/css/index.css' and updating the JavaScript in 'assets/js/script.js' to replace markdown-style headings with the appropriate HTML tags. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @x1xo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -439,6 +439,10 @@ addEventListener('DOMContentLoaded', () => { | |||
| .replace(/__(.+?)__/g, '<u>$1</u>') | |||
| .replace(/\*(.+?)\*/g, '<em>$1</em>') | |||
| .replace(/_(.+?)_/g, '<em>$1</em>') | |||
| //headings | |||
| .replace(/^# (.*)$/gm, '<h1 class="heading1">$1</h1>') | |||
There was a problem hiding this comment.
🚨 issue (security): Consider escaping special characters in heading content.
Escaping special characters in the heading content can help prevent potential XSS vulnerabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request introduces support for headings in the text parser, allowing for H1, H2, and H3 levels. It also includes new CSS classes to style these headings appropriately.