fix usage of fabric impl #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update mod to build on 1.20.1. no changes required
- remove random placeholder suggests in f.m.j
- use TAW rather than fabric api impl detail in CriteriaInit
note that the minecraft dependency is hardcoded to >=1.20 since it doesn't make sense to have it set to `1.20.1` (`${minecraft_version}`), as the mod works on 1.20 and 1.20.1
|
Not sure if you want/need to include it in this Pull Request but when I was building the file I had to modify https://github.com/Globox1997/LevelZ/blob/1.20/build.gradle#L19 From |
|
Yes, that will need to be done. Jfrog ended their free service recently |
Jamalam360
changed the title
Jamalam360
changed the title
|
@Globox1997 do you have any particular gripes with this? It not only fixes compatibility with Quilt but also is just the Fabric recommended way to do things anyways |
This was referenced Aug 15, 2023
|
Too many open github issues, thanks for contributing. |
Jamalam360
added a commit
to Jamalam360/quiltmc.org
that referenced
this pull request
Sep 5, 2023
Southpaw1496
pushed a commit
to QuiltMC/quiltmc.org
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update mod to build on 1.20.1. no changes requiredcloses #285, closes #282, closes #278